shithub: riscv

Info  •  Files  •  Log  •  Branches

devip: don't add default broadcast addresses for ipv4 (thanks cgnarne)

When adding an ip address, we would also add a default
network mask (class A,B,C) in the selftab/routing table
based on the ip address only using defmask().

This can make some addresses unreachable when one uses
classless routing. So remove this, as the add command
already provides the exact netmask that should be used.

--- a/sys/src/9/ip/ipifc.c

+++ b/sys/src/9/ip/ipifc.c

@@ -640,18 +640,6 @@

 			bcast[i] = (ip[i] & mask[i]) & mask[i];

 		addselfcache(f, ifc, lifc, bcast, Rbcast);

-		/* add network directed broadcast address to the self cache */

-		memmove(mask, defmask(ip), IPaddrlen);

-		for(i = 0; i < IPaddrlen; i++)

-			bcast[i] = (ip[i] & mask[i]) | ~mask[i];

-		addselfcache(f, ifc, lifc, bcast, Rbcast);

-

-		/* add network directed network address to the self cache */

-		memmove(mask, defmask(ip), IPaddrlen);

-		for(i = 0; i < IPaddrlen; i++)

-			bcast[i] = (ip[i] & mask[i]) & mask[i];

-		addselfcache(f, ifc, lifc, bcast, Rbcast);

-

 		addselfcache(f, ifc, lifc, IPv4bcast, Rbcast);

 		/* add all nodes multicast address */

-- 

⑨