shithub: furgit

Download patch

ref: 37e4dcd9ba583936a7da9bbcb865c6be448e2c19
parent: ee16d84dcf13e5490dd9504791510851b53a866b
author: Runxi Yu <me@runxiyu.org>
date: Tue Mar 3 16:11:18 EST 2026

config: Fix lints

--- a/config/config.go
+++ b/config/config.go
@@ -10,6 +10,8 @@
 	"math"
 	"strconv"
 	"strings"
+
+	"codeberg.org/lindenii/furgit/internal/intconv"
 )
 
 // Config holds all parsed configuration entries from a Git config file.
@@ -600,7 +602,7 @@
 	if len(s) == 0 {
 		return false
 	}
-	for i := 0; i < len(s); i++ {
+	for i := range len(s) {
 		ch := s[i]
 		if !isLetter(ch) && !isDigit(ch) && ch != '-' && ch != '.' {
 			return false
@@ -638,7 +640,7 @@
 	if err != nil {
 		return 0, err
 	}
-	return int32(n64), nil
+	return intconv.Int64ToInt32(n64)
 }
 
 func parseInt(value string) (int, error) {
@@ -653,7 +655,7 @@
 	return parseInt64WithMax(value, int64(^uint64(0)>>1))
 }
 
-func parseInt64WithMax(value string, max int64) (int64, error) {
+func parseInt64WithMax(value string, maxValue int64) (int64, error) {
 	if value == "" {
 		return 0, errors.New("empty value")
 	}
@@ -685,8 +687,8 @@
 		return 0, err
 	}
 
-	intMax := max
-	intMin := -max - 1
+	intMax := maxValue
+	intMin := -maxValue - 1
 	if n > 0 && n > intMax/factor {
 		return 0, errors.New("integer overflow")
 	}
@@ -699,7 +701,7 @@
 }
 
 func truncateAtNUL(value string) string {
-	for i := 0; i < len(value); i++ {
+	for i := range len(value) {
 		if value[i] == 0 {
 			return value[:i]
 		}
--