shithub: furgit

Download patch

ref: 6375255f0cc648e0a0f26c3b9c461f9959fe8ad5
parent: 481fd4a4c1e9b54ce365db3105c7c71afb0c0e2a
author: Runxi Yu <me@runxiyu.org>
date: Sat Mar 7 12:05:06 EST 2026 

ci, objectstored: Disable ireturn


--- a/.golangci.yaml
+++ b/.golangci.yaml
@@ -8,6 +8,7 @@
       - internal/compress/internal
   disable:
     - dupword          # extremely normal in tests and a pretty unnecessary linter
+    - ireturn          # can't seem to ignore this linter properly and we don't need anyway, cf. tagged unions
     - goconst          # unnecessary especially for our parsing code; many false positives
     - mnd              # unnecessary especially for our parsing code; many false positives
     - lll              # common sense is much better than these sort of rules
--- a/objectstored/blob.go
+++ b/objectstored/blob.go
@@ -25,7 +25,7 @@
 }
 
 // Object returns the parsed blob as the generic object interface.
-func (stored *StoredBlob) Object() object.Object { //nolint:ireturn
+func (stored *StoredBlob) Object() object.Object {
 	return stored.blob
 }
 
--- a/objectstored/commit.go
+++ b/objectstored/commit.go
@@ -22,7 +22,7 @@
 }
 
 // Object returns the parsed commit as the generic object interface.
-func (stored *StoredCommit) Object() object.Object { //nolint:ireturn
+func (stored *StoredCommit) Object() object.Object {
 	return stored.commit
 }
 
--- a/objectstored/objectstored.go
+++ b/objectstored/objectstored.go
@@ -22,7 +22,7 @@
 }
 
 // Object returns the parsed tag as the generic object interface.
-func (stored *StoredTag) Object() object.Object { //nolint:ireturn
+func (stored *StoredTag) Object() object.Object {
 	return stored.tag
 }
 
--- a/objectstored/tree.go
+++ b/objectstored/tree.go
@@ -22,7 +22,7 @@
 }
 
 // Object returns the parsed tree as the generic object interface.
-func (stored *StoredTree) Object() object.Object { //nolint:ireturn
+func (stored *StoredTree) Object() object.Object {
 	return stored.tree
 }
 
-- 
⑨