shithub: furgit

Info  •  Files  •  Log  •  Branches

internal/testgit: why not make it more annoying to use ambient authority

--- a/internal/testgit/repo_properties.go

+++ b/internal/testgit/repo_properties.go

@@ -12,9 +12,9 @@

 	return append([]string(nil), testRepo.env...)

 }

-// DirButYouShouldReallyNotUseThisOkay returns the git dir of a repo.

+// DirButYouShouldReallyNotUseThisYouShouldReallyConsiderUsingAProperCapabilityInterfaceInsteadAndIAmKeepingThisMethodIntentionallyLongToAnnoyYou returns the git dir of a repo.

 // Consider using a properly capability interface such as

 // os.Root instead; all uses of ambient path authority must be justified.

-func (testRepo *TestRepo) DirButYouShouldReallyNotUseThisOkay() string {

+func (testRepo *TestRepo) DirButYouShouldReallyNotUseThisYouShouldReallyConsiderUsingAProperCapabilityInterfaceInsteadAndIAmKeepingThisMethodIntentionallyLongToAnnoyYou() string {

 	return testRepo.dir

 }

-- 

⑨