shithub: furgit

Download patch

ref: 9d7ccb0106499f22fb0c215e149e9ed63af891fc
parent: 2493e63454b15c2124dcf669849377f61f0d5243
author: Runxi Yu <me@runxiyu.org>
date: Sun Mar 8 09:30:25 EDT 2026 

receivepack: Period punctuate progress messages


--- a/receivepack/service/apply.go
+++ b/receivepack/service/apply.go
@@ -21,7 +21,7 @@
 			_ = tx.Abort()
 
 			fillCommandErrors(result, commands, err.Error())
-			utils.WriteProgressf(service.opts.Progress, "updating refs: failed at %d/%d\n", i+1, total)
+			utils.WriteProgressf(service.opts.Progress, "updating refs: failed at %d/%d.\n", i+1, total)
 
 			return nil
 		}
@@ -32,7 +32,7 @@
 	err = tx.Commit()
 	if err != nil {
 		fillCommandErrors(result, commands, err.Error())
-		utils.WriteProgressf(service.opts.Progress, "updating refs: failed at commit\n")
+		utils.WriteProgressf(service.opts.Progress, "updating refs: failed at commit.\n")
 
 		return nil
 	}
@@ -63,7 +63,7 @@
 
 	batchResults, err := batch.Apply()
 	if err != nil && len(batchResults) == 0 {
-		utils.WriteProgressf(service.opts.Progress, "updating refs: failed at apply\n")
+		utils.WriteProgressf(service.opts.Progress, "updating refs: failed at apply.\n")
 
 		return err
 	}
@@ -90,7 +90,7 @@
 	if failedCount == 0 {
 		utils.WriteProgressf(service.opts.Progress, "updating refs: done.\n")
 	} else {
-		utils.WriteProgressf(service.opts.Progress, "updating refs: failed (%d/%d)\n", failedCount, total)
+		utils.WriteProgressf(service.opts.Progress, "updating refs: failed (%d/%d).\n", failedCount, total)
 	}
 
 	return nil
--- a/receivepack/service/execute.go
+++ b/receivepack/service/execute.go
@@ -84,7 +84,7 @@
 
 		err = service.promoteQuarantine(quarantineName, quarantineRoot)
 		if err != nil {
-			utils.WriteProgressf(service.opts.Progress, "promoting quarantine: failed: %v\n", err)
+			utils.WriteProgressf(service.opts.Progress, "promoting quarantine: failed: %v.\n", err)
 
 			result.UnpackError = err.Error()
 			fillCommandErrors(result, req.Commands, err.Error())
--- a/receivepack/service/ingest_quarantine.go
+++ b/receivepack/service/ingest_quarantine.go
@@ -17,7 +17,7 @@
 	}
 
 	if req.Pack == nil {
-		utils.WriteProgressf(service.opts.Progress, "unpack failed: missing pack stream\n")
+		utils.WriteProgressf(service.opts.Progress, "unpack failed: missing pack stream.\n")
 
 		result.UnpackError = "missing pack stream"
 		fillCommandErrors(result, commands, "missing pack stream")
@@ -26,7 +26,7 @@
 	}
 
 	if service.opts.ObjectsRoot == nil {
-		utils.WriteProgressf(service.opts.Progress, "unpack failed: objects root not configured\n")
+		utils.WriteProgressf(service.opts.Progress, "unpack failed: objects root not configured.\n")
 
 		result.UnpackError = "objects root not configured"
 		fillCommandErrors(result, commands, "objects root not configured")
@@ -45,7 +45,7 @@
 		},
 	)
 	if err != nil {
-		utils.WriteProgressf(service.opts.Progress, "unpack failed: %v\n", err)
+		utils.WriteProgressf(service.opts.Progress, "unpack failed: %v.\n", err)
 
 		result.UnpackError = err.Error()
 		fillCommandErrors(result, commands, err.Error())
@@ -56,7 +56,7 @@
 	if pending.Header().ObjectCount == 0 {
 		discarded, err := pending.Discard()
 		if err != nil {
-			utils.WriteProgressf(service.opts.Progress, "unpack failed: %v\n", err)
+			utils.WriteProgressf(service.opts.Progress, "unpack failed: %v.\n", err)
 
 			result.UnpackError = err.Error()
 			fillCommandErrors(result, commands, err.Error())
@@ -83,7 +83,7 @@
 
 	quarantineName, quarantineRoot, err := service.createQuarantineRoot()
 	if err != nil {
-		utils.WriteProgressf(service.opts.Progress, "unpack failed: %v\n", err)
+		utils.WriteProgressf(service.opts.Progress, "unpack failed: %v.\n", err)
 
 		result.UnpackError = err.Error()
 		fillCommandErrors(result, commands, err.Error())
@@ -93,7 +93,7 @@
 
 	quarantinePackRoot, err := service.openQuarantinePackRoot(quarantineRoot)
 	if err != nil {
-		utils.WriteProgressf(service.opts.Progress, "unpack failed: %v\n", err)
+		utils.WriteProgressf(service.opts.Progress, "unpack failed: %v.\n", err)
 
 		result.UnpackError = err.Error()
 		fillCommandErrors(result, commands, err.Error())
@@ -112,7 +112,7 @@
 	_ = quarantinePackRoot.Close()
 
 	if err != nil {
-		utils.WriteProgressf(service.opts.Progress, "unpack failed: %v\n", err)
+		utils.WriteProgressf(service.opts.Progress, "unpack failed: %v.\n", err)
 
 		result.UnpackError = err.Error()
 		fillCommandErrors(result, commands, err.Error())
--- a/receivepack/service/run_hook.go
+++ b/receivepack/service/run_hook.go
@@ -34,7 +34,7 @@
 
 	quarantinedObjects, err := service.openQuarantinedObjects(quarantineName)
 	if err != nil {
-		utils.WriteProgressf(service.opts.Progress, "running hooks: failed: %v\n", err)
+		utils.WriteProgressf(service.opts.Progress, "running hooks: failed: %v.\n", err)
 
 		return nil, nil, nil, false, err.Error()
 	}
@@ -52,13 +52,13 @@
 		IO:                 service.opts.HookIO,
 	})
 	if err != nil {
-		utils.WriteProgressf(service.opts.Progress, "running hooks: failed: %v\n", err)
+		utils.WriteProgressf(service.opts.Progress, "running hooks: failed: %v.\n", err)
 
 		return nil, nil, nil, false, err.Error()
 	}
 
 	if len(decisions) != len(commands) {
-		utils.WriteProgressf(service.opts.Progress, "running hooks: failed: wrong decision count\n")
+		utils.WriteProgressf(service.opts.Progress, "running hooks: failed: wrong decision count.\n")
 
 		return nil, nil, nil, false, "hook returned wrong number of update decisions"
 	}
-- 
⑨