ref: db2ea1fbc5ccc13f9bbc5a38abf4c55390265fdb
parent: 5b7b35ea3ad3901a495ff378b6bfdd7d64f2ed67
author: Runxi Yu <me@runxiyu.org>
date: Sat Mar 7 21:31:17 EST 2026
cmd/receivepack9418: Lint
--- a/cmd/receivepack9418/conn.go
+++ b/cmd/receivepack9418/conn.go
@@ -21,7 +21,9 @@
if err != nil { writeErrPkt(writer, fmt.Sprintf("invalid initial request: %v", err))_ = writer.Flush()
+
log.Printf("receivepack9418: %s: invalid initial request: %v", conn.RemoteAddr(), err)+
return
}
@@ -28,7 +30,9 @@
if req.Command != "git-receive-pack" { writeErrPkt(writer, fmt.Sprintf("unsupported command %q", req.Command))_ = writer.Flush()
+
log.Printf("receivepack9418: %s: unsupported command %q", conn.RemoteAddr(), req.Command)+
return
}
@@ -45,6 +49,7 @@
err = receivepack.ReceivePack(context.Background(), writer, reader, opts)
if err != nil {_ = writer.Flush()
+
log.Printf(
"receivepack9418: %s: receive-pack failed (path=%q host=%q extras=%v): %v",
conn.RemoteAddr(),
@@ -60,6 +65,7 @@
err = writer.Flush()
if err != nil { log.Printf("receivepack9418: %s: flush failed: %v", conn.RemoteAddr(), err)+
return
}
}
--- a/cmd/receivepack9418/request.go
+++ b/cmd/receivepack9418/request.go
@@ -21,6 +21,7 @@
}
commandPath := string(parts[0])
+
command, pathname, ok := strings.Cut(commandPath, " ")
if !ok || command == "" || pathname == "" { return gitProtoRequest{}, fmt.Errorf("malformed command/path segment %q", commandPath)--- a/cmd/receivepack9418/run.go
+++ b/cmd/receivepack9418/run.go
@@ -15,6 +15,7 @@
if err != nil { return fmt.Errorf("open repo root: %w", err)}
+
defer func() { _ = repoRoot.Close() }()repo, err := repository.Open(repoRoot)
@@ -21,6 +22,7 @@
if err != nil { return fmt.Errorf("open repository: %w", err)}
+
defer func() { _ = repo.Close() }() objectsRoot, err := repoRoot.OpenRoot("objects")@@ -27,6 +29,7 @@
if err != nil { return fmt.Errorf("open objects root: %w", err)}
+
defer func() { _ = objectsRoot.Close() }() srv := &server{@@ -38,6 +41,7 @@
if err != nil { return fmt.Errorf("listen %q: %w", listenAddr, err)}
+
defer func() { _ = ln.Close() }() log.Printf("receivepack9418: listening on %s", listenAddr)@@ -53,6 +57,7 @@
var nerr net.Error
if errors.As(err, &nerr) && nerr.Temporary() { log.Printf("receivepack9418: temporary accept error: %v", err)+
continue
}
--
⑨