shithub: front

Info  •  Files  •  Log  •  Branches

devsegment: remove useless waserror()

segpage() cannot error(), the waserror() is not needed.

--- a/sys/src/9/port/devsegment.c

+++ b/sys/src/9/port/devsegment.c

@@ -366,13 +366,8 @@

 				if(!iseve())

 					error(Eperm);

 				s = newseg(SG_STICKY, va, len/BY2PG);

-				if(waserror()){

-					putseg(s);

-					nexterror();

-				}

 				for(; va < s->top; va += BY2PG)

 					segpage(s, newpage(1, nil, va));

-				poperror();

 				g->s = s;

 			} else

 				g->s = newseg(SG_SHARED, va, len/BY2PG);

@@ -475,6 +470,7 @@

 		putseg(s);

 		nexterror();

 	}

+

 	lock(&palloc);

 	i = 0;

 	l = palloc.pages;

@@ -525,10 +521,12 @@

 			zeropage(p);

 			segpage(s, p);

 		} while(p != l);

+

 		poperror();

 		return s;

 	}

 	unlock(&palloc);

+

 	error(Enomem);

 }

-- 

⑨