shithub: front

Info  •  Files  •  Log  •  Branches

kernel: fix memory leak in procctlmemio()

Only take a reference of the segment after smalloc() succeeded,
as smalloc() can error(), so we'd leak the segment.

--- a/sys/src/9/port/devproc.c

+++ b/sys/src/9/port/devproc.c

@@ -1672,7 +1672,6 @@

 	} else {

 		qunlock(s);

 	}

-	incref(s);		/* for us while we copy */

 	poperror();

 	sio = c->aux;

 	if(sio == nil){

@@ -1679,6 +1678,7 @@

 		sio = smalloc(sizeof(Segio));

 		c->aux = sio;

 	}

+	incref(s);		/* for us while we copy */

 	qunlock(&p->seglock);

 	poperror();

-- 

⑨