shithub: front

Download patch

ref: c7fd84937c525ad94eefad0fd978acc0da301092
parent: eb76dc48cdcfb97b1d0f42e7f5f498d914dc8e71
author: cinap_lenrek <cinap_lenrek@felloff.net>
date: Mon Oct 28 20:17:34 EDT 2024 

ip/ipconfig: don't use sprint() when we have variable strings.


--- a/sys/src/cmd/ip/ipconfig/dhcp.c
+++ b/sys/src/cmd/ip/ipconfig/dhcp.c
@@ -603,9 +603,9 @@
 
 	if (validip(conf.laddr) &&
 	    (conf.state == Srenewing || conf.state == Srebinding))
-		sprint(data, "%s/udp!%I!68", conf.mpoint, conf.laddr);
+		snprint(data, sizeof(data), "%s/udp!%I!68", conf.mpoint, conf.laddr);
 	else
-		sprint(data, "%s/udp!*!68", conf.mpoint);
+		snprint(data, sizeof(data), "%s/udp!*!68", conf.mpoint);
 	for (n = 0; (cfd = announce(data, devdir)) < 0; n++) {
 		if(!noconfig)
 			sysfatal("can't announce for dhcp: %r");
@@ -622,7 +622,7 @@
 
 	fprint(cfd, "ignoreadvice");
 
-	sprint(data, "%s/data", devdir);
+	snprint(data, sizeof(data), "%s/data", devdir);
 	fd = open(data, ORDWR);
 	if(fd < 0)
 		sysfatal("open %s: %r", data);
--- a/sys/src/cmd/ip/ipconfig/dhcpv6.c
+++ b/sys/src/cmd/ip/ipconfig/dhcpv6.c
@@ -37,7 +37,7 @@
 	int n, fd, cfd;
 	char data[128], devdir[40];
 
-	sprint(data, "%s/udp!%I!546", conf.mpoint, conf.lladdr);
+	snprint(data, sizeof(data), "%s/udp!%I!546", conf.mpoint, conf.lladdr);
 	for (n = 0; (cfd = announce(data, devdir)) < 0; n++) {
 		if(!noconfig)
 			sysfatal("can't announce for dhcp: %r");
@@ -54,7 +54,7 @@
 
 	fprint(cfd, "ignoreadvice");
 
-	sprint(data, "%s/data", devdir);
+	snprint(data, sizeof(data), "%s/data", devdir);
 	fd = open(data, ORDWR);
 	if(fd < 0)
 		sysfatal("open %s: %r", data);
-- 
⑨