shithub: front

Info  •  Files  •  Log  •  Branches

git/get: don't fetch all prefixes by default

we should really only be fetching heads/ or tags/, and not
other refs; in addition to being able to clobber local refs,
on github anyone can open a pull request against a repo, and
we probably don't want to grab those refs by default.

--- a/sys/src/cmd/git/get.c

+++ b/sys/src/cmd/git/get.c

@@ -135,13 +135,19 @@

 }

 int

+prefixed(char *s, char *pfx)

+{

+	return strncmp(s, pfx, strlen(pfx)) == 0;

+}

+

+int

 branchmatch(char *br, char *pat)

 {

 	char name[128];

-	if(strstr(pat, "refs/heads") == pat)

+	if(prefixed(pat, "refs/heads"))

 		snprint(name, sizeof(name), "%s", pat);

-	else if(strstr(pat, "heads"))

+	else if(prefixed(pat, "heads/"))

 		snprint(name, sizeof(name), "refs/%s", pat);

 	else

 		snprint(name, sizeof(name), "refs/heads/%s", pat);

@@ -264,6 +270,8 @@

 		if(!okrefname(sp[1]))

 			sysfatal("remote side sent invalid ref: %s", sp[1]);

 		if(fetchbranch && !branchmatch(sp[1], fetchbranch))

+			continue;

+		else if(!prefixed(sp[1], "refs/heads/") && !prefixed(sp[1], "refs/tags/"))

 			continue;

 		if(refsz == nref + 1){

 			refsz *= 2;

-- 

⑨